No check for signature malleability

[code423n4]

Handle

cmichel

Vulnerability details

The SignatureValidator.recoverAddrImpl function does not check for malleable signatures. Without this check, anyone can derive a second, different but valid signature (for the same message).

Impact

As nonces are used and the signature bytes are never used themselves, not checking for malleability does not lead to issues.

Recommended Mitigation Steps

You might or might not want to implement these additional checks, depending on gas costs.

[Ivshti]

As you said, because of the nonces, as well as not using the sig bytes as identifying data, this is a non-issue. Marking as resolved

[GalloDaSballo]

The finding is valid There is no impact Will downgrade to Non Critical