code-423n4 / 2021-10-ambire-findings

0 stars 0 forks source link

Gas: `BytesLib` addition can be unchecked #41

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

cmichel

Vulnerability details

The index += 32 addition in readBytes32 can be put in an unsafe block as the array length is already checked to be greater than the addition.

Ivshti commented 2 years ago

resolved https://github.com/AmbireTech/adex-protocol-eth/commit/282fdb03e7da531696ccdb47596d84369c5b70f1

GalloDaSballo commented 2 years ago

Agree with the finding, the sponsor has implemented the improvement