Closed code423n4 closed 2 years ago
JMukesh
due to unchecked return value from token.transfer() , transaction may silently fail because some token do not revert on failure
https://github.com/code-423n4/2021-10-ambire/blob/bc01af4df3f70d1629c4e22a72c19e6a814db70d/contracts/wallet/Zapper.sol#L226
https://github.com/code-423n4/2021-10-ambire/blob/bc01af4df3f70d1629c4e22a72c19e6a814db70d/contracts/IdentityFactory.sol#L52
manual review
use safeTransfer()
duplicate of #35
Handle
JMukesh
Vulnerability details
Impact
due to unchecked return value from token.transfer() , transaction may silently fail because some token do not revert on failure
Proof of Concept
https://github.com/code-423n4/2021-10-ambire/blob/bc01af4df3f70d1629c4e22a72c19e6a814db70d/contracts/wallet/Zapper.sol#L226
https://github.com/code-423n4/2021-10-ambire/blob/bc01af4df3f70d1629c4e22a72c19e6a814db70d/contracts/IdentityFactory.sol#L52
Tools Used
manual review
Recommended Mitigation Steps
use safeTransfer()