code-423n4 / 2021-10-ambire-findings

0 stars 0 forks source link

LibBytes uses itself #58

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

I don't think it's necessary for the library to use itself here: library LibBytes { using LibBytes for bytes;

Recommended Mitigation Steps

Remove this 'using' statement as it does not give anything in this case.

Ivshti commented 2 years ago

resolved in https://github.com/AmbireTech/adex-protocol-eth/commit/282fdb03e7da531696ccdb47596d84369c5b70f1

GalloDaSballo commented 2 years ago

Agree with the finding, theusing statement is not necessary The sponsor has applied the improvement