code-423n4 / 2021-10-ambire-findings

0 stars 0 forks source link

Set `IdentityFactory::creator` as immutable #6

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pmerkleplant

Vulnerability details

Impact

Variable creator in the IdentityFactory is never reset after initialization in the constructor. Declaring it as immutable saves gas.

Ivshti commented 2 years ago

fixed in https://github.com/AmbireTech/adex-protocol-eth/commit/86ca920859fe8c9508245e4efc29f52c976cf3fe

GalloDaSballo commented 2 years ago

Agreed

The sponsor has applied the improvment