search

code-423n4 / 2021-10-ambire-findings

0 stars 0 forks source link

create2 assembly #67

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

You don't need to use assembly to access create2 in Solidity anymore: https://docs.soliditylang.org/en/latest/control-structures.html#salted-contract-creations-create2

Recommended Mitigation Steps

Consider getting rid of assembly create2 in favor of official recommendations.

Ivshti commented 2 years ago

We're aware of this but at this point we're trying to change as little code as possible (only critical fixes), so this is a wontfix

GalloDaSballo commented 2 years ago

Sponsor acknowledges, I agree that the change can be a wontfix and the finding is valid and non-critical

Ivshti commented 2 years ago

@GalloDaSballo also it should be noted, this is actually impossible to fix cause in pure solidity we can't provide custom bytecode