issues
search
code-423n4
/
2021-10-badgerdao-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
`WrappedIbbtcEth.sol` Does Not Incentivize Price Updates
#94
code423n4
closed
2 years ago
1
Front-running displacement to beat oracle updates for price manipulation
#93
code423n4
closed
2 years ago
2
Use immutable keyword on ibbtc interface
#92
code423n4
closed
2 years ago
2
Use Minimal Interface for gas optimizations
#91
code423n4
opened
2 years ago
1
Null check in pricePerShare
#90
code423n4
opened
2 years ago
1
Logical issue in governance event emission
#89
code423n4
closed
2 years ago
3
inconsistent use of msg.sender and _msgSender()
#88
code423n4
closed
2 years ago
3
WrappedIbbtc and WrappedIbbtcEth contracts do not filter out price feed outliers
#87
code423n4
opened
2 years ago
1
WrappedIbbtcEth contract will use stalled price for mint/burn if updatePricePerShare wasn't run properly
#86
code423n4
opened
2 years ago
2
In updatePricePerShare() no value is returned
#85
code423n4
opened
2 years ago
0
No address(0) validation in initialize()
#84
code423n4
closed
2 years ago
2
use of depreciated "now"
#83
code423n4
opened
2 years ago
2
Check if amount is not zero
#82
code423n4
opened
2 years ago
0
Immutable variable
#81
code423n4
opened
2 years ago
1
onlyOracle never used
#80
code423n4
opened
2 years ago
0
ICore import
#79
code423n4
opened
2 years ago
0
modified _balances in OZ contract
#78
code423n4
opened
2 years ago
1
balanceToShares should handle division by 0 case
#77
code423n4
closed
2 years ago
1
Consider making contracts Pausable
#76
code423n4
opened
2 years ago
1
updatePricePerShare does not return declared value
#75
code423n4
closed
2 years ago
1
pendingGovernance and Governace address can be same
#74
code423n4
opened
2 years ago
3
Lack of input validation in settng PendingGovernance
#73
code423n4
closed
2 years ago
1
lack of access modifier in Initialize()
#72
code423n4
closed
2 years ago
3
use of floating pragma
#71
code423n4
opened
2 years ago
0
PREVENT DIV BY 0
#70
code423n4
opened
2 years ago
0
Deprecated Function Usage
#69
code423n4
opened
2 years ago
0
No sanity check on pricePerShare might lead to lost value
#68
code423n4
opened
2 years ago
0
Inconsistent use of `_msgSender()`
#67
code423n4
closed
2 years ago
2
pricePerShare might become stale and cause to lose user funds, as update is not enforced
#66
code423n4
closed
2 years ago
1
The design of `wibBTC` is not fully compatible with the current Curve StableSwap pool
#65
code423n4
opened
2 years ago
1
Redundant use of `virtual`
#64
code423n4
opened
2 years ago
0
`transferFrom` amount may exceed allowance
#63
code423n4
closed
2 years ago
1
The `value` parameter of the `Transfer` event is wrong
#62
code423n4
opened
2 years ago
2
`updatePricePerShare` should be run atomically with `setCore()` to make sure `pricePerShare` is up-to-date with the new Core
#61
code423n4
opened
2 years ago
1
Critical changes should use two-step procedure
#60
code423n4
opened
2 years ago
2
`WrappedIbbtcEth.sol` Sanity check of `pricePerShare` should be enforced
#59
code423n4
closed
2 years ago
1
Avoid unnecessary external calls and storage writes can save gas
#58
code423n4
opened
2 years ago
1
Constants are not explicitly declared
#57
code423n4
opened
2 years ago
0
Consider removing `ICore.sol`
#56
code423n4
opened
2 years ago
0
Consider caching `pricePerShare` for `WrappedIbbtc.sol` to save gas
#55
code423n4
opened
2 years ago
1
Inconsistent use of `_msgSender()`
#54
code423n4
opened
2 years ago
0
Methods should be declared external
#53
code423n4
closed
2 years ago
1
Missing error messages in require statements
#52
code423n4
opened
2 years ago
0
Cache external call result in the stack can save gas
#51
code423n4
opened
2 years ago
0
Outdated versions of OpenZeppelin library
#50
code423n4
opened
2 years ago
0
Outdated compiler version
#49
code423n4
opened
2 years ago
0
Avoid unnecessary storage read can save gas
#48
code423n4
opened
2 years ago
0
Unused code
#47
code423n4
closed
2 years ago
1
Events are emitting storage vars instead of user/system values
#46
code423n4
opened
2 years ago
0
Gas: Event parameters read from storage
#45
code423n4
opened
2 years ago
0
Next