code-423n4 / 2021-10-covalent-findings

0 stars 0 forks source link

Use constant to save gas #62

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

jonah1005

Vulnerability details

Impact

divider is set to 1e18. We can save a lot of SLOAD if we use a constant instead.

Proof of Concept

https://github.com/code-423n4/2021-10-covalent/blob/main/contracts/DelegatedStaking.sol#L9

Tools Used

None

Recommended Mitigation Steps

Please refer to the solidity doc. https://docs.soliditylang.org/en/latest/contracts.html#constant-and-immutable-state-variables

kitti-katy commented 2 years ago

duplicate of #27

GalloDaSballo commented 2 years ago

Duplicate of #27