search

code-423n4 / 2021-10-defiprotocol-findings

0 stars 0 forks source link

Unused Named Returns Can Be Removed #4

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

ye0lde

Vulnerability details

Impact

Removing unused named return variables can reduce gas usage and improve code clarity.

Proof of Concept

The unused named return variable is here (Factory.sol):

https://github.com/code-423n4/2021-10-defiprotocol/blob/7ca848f2779e2e64ed0b4756c02f0137ecd73e50/contracts/contracts/Factory.sol#L71

Tools Used

VS Code

Recommended Mitigation Steps

Remove the unused named return variable - "id"

GalloDaSballo commented 2 years ago

Valid finding