code-423n4 / 2021-10-defiprotocol-findings

0 stars 0 forks source link

Events in `IAuction` don't use the `indexed` keyword #44

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pants

Vulnerability details

The events defined in IAuction don't use the indexed keyword for any of their values.

Impact

Users can't easily keep track of logged events, resulting with a poor user experience.

Tool Used

Manual code review.

Recommended Mitigation Steps

Use the indexed keyword whenever necessary for these events.

GalloDaSballo commented 2 years ago

Personal opinion here as I believe you can still filter unindexed parameters, and using theGraph makes this a non-issue, that said, the sponsor acknowledges so let's mark as valid