search

code-423n4 / 2021-10-mochi-findings

0 stars 0 forks source link

Missing low-level call success check #132

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

The MochiVaultProxy.updateTemplate performs a low-level call to beacon and does not check the success return value.

Impact

If the beacon is set to the wrong address and the call fails, it will not be noticeable.

Recommended Mitigation Steps

Check for success for the address(beacon).call(abi.encode(_newTemplate)) call.

r2moon commented 3 years ago

duplicated with https://github.com/code-423n4/2021-10-mochi-findings/issues/76