code-423n4 / 2021-10-mochi-findings

0 stars 0 forks source link

Events on key Vault actions #146

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

hyh

Vulnerability details

Description

User requested key actions: {mint, borrow, repay, deposit, and withdraw} should be paired with the corresponding events emittance. For example, in increase function when new position NFT id is generated and then deposited to, this newly allocated id to be communicated to a user. https://github.com/code-423n4/2021-10-mochi/blob/main/projects/mochi-core/contracts/vault/MochiVault.sol#L113

Recommended Mitigation Steps

All MochiVault public user functions should have corresponding events issuance as the last actions for the corresponding code

r2moon commented 3 years ago

duplicated with https://github.com/code-423n4/2021-10-mochi-findings/issues/84