code-423n4 / 2021-10-pooltogether-findings

0 stars 0 forks source link

state variables that can be declared as immutable #12

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

pants

Vulnerability details

YieldSourcePrizePool.sol. The state variable yieldSource should be immutable. (can be set only once only at the constructor) Also at ControlledToken.sol, if you don’t want to allow to change the controller (no function for it) then make the controller immutable.

PierrickGT commented 3 years ago

PR: https://github.com/pooltogether/v4-core/pull/226

PierrickGT commented 3 years ago

Duplicate of https://github.com/code-423n4/2021-10-pooltogether-findings/issues/47

GalloDaSballo commented 3 years ago

Duplicate of #47