code-423n4 / 2021-10-pooltogether-findings

0 stars 0 forks source link

Usage of deprecated `safeApprove` #18

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

Description: safeApprove is now deprecated, see this comment.

Impact

When using one of these unsupported tokens, all transactions revert and the protocol cannot be used.

Recommended Mitigation Steps

As per OpenZepplin documentation “whenever possible, use safeIncreaseAllowance and safeDecreaseAllowance instead”.

PierrickGT commented 3 years ago

PR: https://github.com/pooltogether/v4-core/pull/220

GalloDaSballo commented 3 years ago

The sponsor acknowledges and has mitigated in a subsequent PR