code-423n4 / 2021-10-pooltogether-findings

0 stars 0 forks source link

functions could be private #9

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

pants

Vulnerability details

PrizeSplit.sol _getPrizeSplitAmount could be private. At the same file also PrizeSplit._totalPrizeSplitPercentageAmount could be private. This issue appears in many more places.

asselstine commented 3 years ago

It doesn't optimize gas

PierrickGT commented 3 years ago

We have decided to keep functions internal in case we need to extend them in other contracts in the future. It will be easier for us to maintain and make changes to our codebase. Also, as Brendan mentioned, it doesn't decrease gas cost.

GalloDaSballo commented 3 years ago

Agree with the sponsor in that finding doesn't improve gas efficiency Additionally, the functions are under the "Internal Functions" section of the contract

Invalid