code-423n4 / 2021-10-slingshot-findings

0 stars 0 forks source link

payable functions are gas consuming #14

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pants

Vulnerability details

As much as I understand, executeTrades should not be payable and removing the playability will save gas.

tommyz7 commented 2 years ago

executeTrades must be payable becasue it accepts ETH

alcueca commented 2 years ago

Dispute accepted