code-423n4 / 2021-10-slingshot-findings

0 stars 0 forks source link

Unnecessary Use of _msgSender() #22

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

zer0dot

Vulnerability details

Impact

The use of _msgSender() when there is no implementation of a meta transaction mechanism that uses it, such as EIP-2771, very slightly increases gas consumption.

Proof of Concept

_msgSender() is utilized three times where msg.sender could have been used in this function.

Recommended Mitigation Steps

Replace _msgSender() with msg.sender if there is no mechanism to support meta-transactions like EIP-2771 implemented.