code-423n4 / 2021-10-slingshot-findings

0 stars 0 forks source link

Flaws in Slingshot._sendFunds() #24

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

daejunpark

Vulnerability details

Impact

Although it is not currently used, the Slingshot._sendFunds() function sends the given amount twice, which can be badly exploited for the double spending attack, in case that the function happens to be utilized in the later version of the code.

Recommendation

Fix the function to send the amount only once (e.g., by removing the line 170), or remove the unused function altogether.