search

code-423n4 / 2021-10-slingshot-findings

0 stars 0 forks source link

Confusing comment in CurveModule #85

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

kenzo

Vulnerability details

There's a comment in CurveModule: the only unique logic in this contract calculates post-trade balance because Curve's innovative design choice of not returning an output amount. https://github.com/code-423n4/2021-10-slingshot/blob/main/contracts/module/CurveModule.sol#L26:#L27 However, there seems to be no such calculation in the module. https://github.com/code-423n4/2021-10-slingshot/blob/main/contracts/module/CurveModule.sol#L57:#L59

It is unclear whether the check should be there, what it's purpose is, and if something is wrong as the check is missing. I suggest clarifying the comment.

tommyz7 commented 2 years ago

Outdated comment, however I don't see where's a risk here. In my opinion it's non-critical.

alcueca commented 2 years ago

Issues with comments and classified as severity 1.