code-423n4 / 2021-10-slingshot-findings

0 stars 0 forks source link

dead code #99

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

function _sendFunds in Slingshot is internal and never used so it is basically a dead code (even unsafe as it sends funds twice). You should remove this code to eliminate the confusion and reduce gas costs.

function prependNumber in ConcatStrings is not used so it can also be removed to reduce deployment costs.

Recommended Mitigation Steps

Get rid of dead code.

tommyz7 commented 2 years ago

Duplicate of #24