code-423n4 / 2021-10-tally-findings

0 stars 0 forks source link

Inclusive check #49

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

According to the err msg here, the check should be inclusive <= : require(swapFee_ < SWAP_FEE_DIVISOR, "Swap::setSwapFee: Swap fee must not exceed 100%");

Recommended Mitigation Steps

require(swapFee_ <= SWAP_FEE_DIVISOR, "Swap::setSwapFee: Swap fee must not exceed 100%");

Shadowfiend commented 2 years ago

Quite the edge case :grin: We may try to adjust this if we get in there, depending on what we decide to do about #10 .