code-423n4 / 2021-10-tally-findings

0 stars 0 forks source link

FeesSwept will emit 0 amounts for ETH #52

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Here the FeesSwept event will always emit 0 amount as this.balance is already transferred an nothing left in the contract: feeRecipient.transfer(address(this).balance); emit FeesSwept(address(0), address(this).balance, feeRecipient);

Recommended Mitigation Steps

uint balance = address(this).balance; feeRecipient.transfer(balance); emit FeesSwept(address(0), balance, feeRecipient);

Shadowfiend commented 2 years ago

Duplicate of #21.