The function Swap.setFeeRecipient() emits a NewFeeRecipient when the value of feeRecipient_ equals the same feeRecipient from before that transaction and the fee recipient hasn't changed.
Impact
This event is emitted although it shouldn't, so it can confuse users.
Tool Used
Manual code review.
Recommended Mitigation Steps
Emit this event only if feeRecipient_ doesn't equal the original feeRecipient, or revert when they are equal.
Handle
pants
Vulnerability details
The function
Swap.setFeeRecipient()
emits aNewFeeRecipient
when the value offeeRecipient_
equals the samefeeRecipient
from before that transaction and the fee recipient hasn't changed.Impact
This event is emitted although it shouldn't, so it can confuse users.
Tool Used
Manual code review.
Recommended Mitigation Steps
Emit this event only if
feeRecipient_
doesn't equal the originalfeeRecipient
, or revert when they are equal.