search

code-423n4 / 2021-10-tally-findings

0 stars 0 forks source link

`Swap.setFeeRecipient()` emits a `NewFeeRecipient` when the fee recipient hasn't changed #67

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pants

Vulnerability details

The function Swap.setFeeRecipient() emits a NewFeeRecipient when the value of feeRecipient_ equals the same feeRecipient from before that transaction and the fee recipient hasn't changed.

Impact

This event is emitted although it shouldn't, so it can confuse users.

Tool Used

Manual code review.

Recommended Mitigation Steps

Emit this event only if feeRecipient_ doesn't equal the original feeRecipient, or revert when they are equal.

Shadowfiend commented 2 years ago

I think this is a 0-non-critical issue.

0xean commented 2 years ago

downgrading, see comment in #66