code-423n4 / 2021-10-tally-findings

0 stars 0 forks source link

`internal` functions can be `private` #70

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pants

Vulnerability details

These internal functions are never called in any contract that inherits their contract:

Swap.fillZrxQuote()
Swap.signifiesETHOrZero()
EmergencyGovernable.governor()

Therefore, their visibility can be reduced to private.

Impact

private functions are cheaper than internal functions.

Tool Used

Manual code review.

Recommended Mitigation Steps

Define these functions as private.