Open code423n4 opened 2 years ago
pants
These internal functions are never called in any contract that inherits their contract:
internal
Swap.fillZrxQuote()
Swap.signifiesETHOrZero()
EmergencyGovernable.governor()
Therefore, their visibility can be reduced to private.
private
private functions are cheaper than internal functions.
Manual code review.
Define these functions as private.
Handle
pants
Vulnerability details
These
internal
functions are never called in any contract that inherits their contract:Swap.fillZrxQuote()
Swap.signifiesETHOrZero()
EmergencyGovernable.governor()
Therefore, their visibility can be reduced to
private
.Impact
private
functions are cheaper thaninternal
functions.Tool Used
Manual code review.
Recommended Mitigation Steps
Define these functions as
private
.