code-423n4 / 2021-10-tempus-findings

0 stars 0 forks source link

depositYieldBearing didn't check address != 0 #48

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pants

Vulnerability details

mijovic commented 2 years ago

There is not enough data in the report, I think what the warden wanted to report is that there was no check for recipient address in TempusController. depositYieldBearing. If that is the case, we fixed it here https://github.com/tempus-finance/tempus-protocol/pull/371

However, I think the severity of this one is 0

0xean commented 2 years ago

downgrading to non-critical. Zero address checks are a good practice but don't prevent many other bad calls or human errors from potentially being made.