code-423n4 / 2021-10-tracer-findings

0 stars 0 forks source link

Unused state variables #31

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

Not used variables. In library PoolSwapLibrary: bytes16 public constant zero = 0x00000000000000000000000000000000; bytes16 private constant NEGATIVE_ZERO = 0x80000000000000000000000000000000; In contract PoolKeeper: uint256 public constant MAX_DECIMALS = 18;

Recommended Mitigation Steps

Remove if you don't need them to save some gas.

GalloDaSballo commented 3 years ago

Disagree with MAX_DECIMALS in PoolKeeper, it is used

Agree for zero and NEGATIVE_ZERO