GalloDaSballo
commented
3 years ago The sponsor confirms and has implemented the recommendation
Closed code423n4 closed 3 years ago
GalloDaSballo
commented
3 years ago The sponsor confirms and has implemented the recommendation
Handle
pauliax
Vulnerability details
Impact
Style issues that you may want to apply or reject, no impact on security. Grouping them together as one submission to reduce waste. Consider fixing or ignoring them, up to you.
Consider replacing your function uint2str with library Strings from OZ: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Strings.sol
Multiple contracts separately define MAX_DECIMALS as 18. While there is no issue with the current contracts, it makes the code harder to maintain as if for some reason you decide to change it in one place, you must also not forget to update the others. For example, here the number of max decimals is hardcoded: require(IERC20DecimalsWrapper(deploymentParameters.quoteToken).decimals() <= 18, "Token decimals > 18");