code-423n4 / 2021-11-badgerzaps-findings

0 stars 0 forks source link

Don't use deprecated library functions #14

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pmerkleplant

Vulnerability details

Impact

Zap.sol, SettToRenIbbtcZap.sol and IbbtcVaultZap.sol use OpenZeppelins SafeERC20::safeApprove function.

This function is marked as deprecated, see OZ repo.

Recommended Mitigation Steps

Use OZ's SafeERC20::safeIncreaseAllowance instead of safeApprove.

GalloDaSballo commented 2 years ago

Disagree as the functions are marked as deprecated for the new versions of the library, we are using 0.6.12, also we only use the safeApprove once, as designed

0xleastwood commented 2 years ago

agree with sponsor. warden has linked the most up-to-date version of the contract.