code-423n4 / 2021-11-badgerzaps-findings

0 stars 0 forks source link

Wrong comment on `SettToRenIbbtcZap.sol` and `IbbtcVaultZap.sol` #16

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

0x0x0x

Vulnerability details

Concept

Both contrats have the comment /// ===== Permissioned Actions: Guardian ===== for pause function, but pause function can be used by Guardian or Governance. I recommend changing the comment to avoid confusions.

SettToRenIbbtcZap.sol#L116 and IbbtcVaultZap.sol#L109

tabshaikh commented 2 years ago

fixed

0xleastwood commented 2 years ago

Keeping issue as low to match judging spec which states issues related to comments are of low severity.