search

code-423n4 / 2021-11-badgerzaps-findings

0 stars 0 forks source link

setGaurdian is changing Governance instead of Gaurdian #24

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

fatima_naz

Vulnerability details

Impact

In file ibBTC VaultZap.sol , The function setGaurdian is setting the governance. First problem is , setGaurdian is supposed to set gaurdian not governance. gaurdian is a different contract which does not have access to many functions, if we are making governance same as gaurdian so now governance also can not call those function.

Proof of Concept

Tools Used

Recommended Mitigation Steps

change the line - governance = _guardian with guardian = _guardian

tabshaikh commented 2 years ago

Similar to #10 , fixed

GalloDaSballo commented 2 years ago

Also similar to #31 agree with the finding, we have fixed the oversight

0xleastwood commented 2 years ago

duplicate of #51