Modifier should be used instead of functions to write modifier in ibBTC VaultZap.sol

[code423n4]

Handle

fatima_naz

Vulnerability details

Impact

In ibBTC VaultZap.sol line no - 91 and 95 Function Modifiers are used to modify the behaviour of a function. For example to add a prerequisite to a function.The main use case of modifiers is for automatically checking a condition, prior to executing a function.

Proof of Concept

https://stackoverflow.com/questions/44982437/what-does-a-modifier-do-in-solidity

Tools Used

Recommended Mitigation Steps

use modifier keyword instead of writing function .

[tabshaikh]

agree good practice to use function modifiers

[GalloDaSballo]

Disagree as inline modifiers are an emergent pattern, that also saves gas

[0xleastwood]

Will keep issue open as non-critical