code-423n4 / 2021-11-badgerzaps-findings

0 stars 0 forks source link

use modifier keyword to write modifier not function In SettToRenIbbtcZap.sol line no - 105 and 109 #27

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

fatima_naz

Vulnerability details

Impact

In SettToRenIbbtcZap.sol line no - 105 and 109 Function Modifiers are used to modify the behaviour of a function. For example to add a prerequisite to a function.The main use case of modifiers is for automatically checking a condition, prior to executing a function.

Proof of Concept

https://stackoverflow.com/questions/44982437/what-does-a-modifier-do-in-solidity

Tools Used

Recommended Mitigation Steps

use modifier keyword instead of writing function .

tabshaikh commented 2 years ago

Good practice to do but non-critical and contract is live

GalloDaSballo commented 2 years ago

Disagree with the finding as arguably in-line modifiers are a emergent feature of solidity, as inlined modifiers saves gas

0xleastwood commented 2 years ago

Keeping issue open as non-critical