code-423n4 / 2021-11-badgerzaps-findings

0 stars 0 forks source link

TODOs List May Leak Important Info & Errors #30

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Meta0xNull

Vulnerability details

Impact

Open TODOs can hint at programming or architectural errors that still need to be fixed.

Proof of Concept

https://github.com/Badger-Finance/badger-ibbtc-utility-zaps/blob/6f700995129182fec81b772f97abab9977b46026/contracts/IbbtcVaultZap.sol#L145

Tools Used

Manual Review

Recommended Mitigation Steps

Fix TODOs List and Remove it.

tabshaikh commented 2 years ago

fixed duplicate of #5