search

code-423n4 / 2021-11-badgerzaps-findings

0 stars 0 forks source link

Open TODOs #67

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pants

Vulnerability details

IbbtcVaultZap line 145 there is an open todo.

Impact

Open TODOs can hint at programming or architectural errors that still need to be fixed.

Tool Used

Manual code review.

Recommended Mitigation Steps

Resolve these TODOs and bubble up the errors.

GalloDaSballo commented 3 years ago

Agree with the finding

0xleastwood commented 2 years ago

Marking issue as non-critical as it does accurately point to an existing issue.

0xleastwood commented 2 years ago

dealing with open TODOs is a best practice.