code-423n4 / 2021-11-badgerzaps-findings

0 stars 0 forks source link

Require statements without messages #68

Closed code423n4 closed 2 years ago

code423n4 commented 3 years ago

Handle

pants

Vulnerability details

These functions contain require statement without messages: IbbtcVaultZap lines 54, 55 SettToRenIbbtcZap lines 55, 56, 167, 168, 189, 190,

Impact

When transactions revert, the users won't receive error messages indicating the cause of the failure.

Tool Used

Manual code review.

Recommended Mitigation Steps

Add informative error messages to the require statements in these functions.

GalloDaSballo commented 3 years ago

Disagree with the finding, a revert without an error message brings no security risk, additionally, during debugs you can still find the line that reverted

0xleastwood commented 2 years ago

agree with sponsor, same as #38