Several public functions can be declared as external

[code423n4]

Handle

Reigada

Vulnerability details

Impact

There are functions marked as public but they are never directly called within the same contract or in any of its descendants, hence they can be declared as external to save some gas:

• FairSideDAO.quorumVotes() (contracts/dao/FairSideDAO.sol#231-233)
• FairSideDAO.getActions(uint256) (contracts/dao/FairSideDAO.sol#272-284)
• FairSideDAO.getReceipt(uint256,address) (contracts/dao/FairSideDAO.sol#289-295)
• FairSideDAO.propose(address[],uint256[],string[],bytes[],string,bool) (contracts/dao/FairSideDAO.sol#376-461)
• FairSideDAO.queue(uint256) (contracts/dao/FairSideDAO.sol#471-490)
• FairSideDAO.execute(uint256) (contracts/dao/FairSideDAO.sol#500-518)
• FairSideDAO.cancel(uint256) (contracts/dao/FairSideDAO.sol#531-563)
• FairSideDAO.castVote(uint256,bool) (contracts/dao/FairSideDAO.sol#569-571)
• FairSideDAO.castVoteBySig(uint256,bool,uint8,bytes32,bytes32) (contracts/dao/FairSideDAO.sol#579-606)
• FairSideDAO.disableOffchainVoting() (contracts/dao/FairSideDAO.sol#619-626)
• FairSideDAO.__castOffchainVotes(uint256,bytes32,uint256,uint256) (contracts/dao/FairSideDAO.sol#636-661)
• FairSideDAO.__acceptAdmin() (contracts/dao/FairSideDAO.sol#671-677)
• FairSideDAO.__abdicate() (contracts/dao/FairSideDAO.sol#685-691)
• FairSideDAO.__queueSetTimelockPendingAdmin(address,uint256) (contracts/dao/FairSideDAO.sol#699-714)
• FairSideDAO.__executeSetTimelockPendingAdmin(address,uint256) (contracts/dao/FairSideDAO.sol#722-737)
• Timelock.setDelay(uint256) (contracts/timelock/Timelock.sol#130-146)
• Timelock.acceptAdmin() (contracts/timelock/Timelock.sol#156-165)
• Timelock.setPendingAdmin(address) (contracts/timelock/Timelock.sol#174-182)
• Timelock.queueTransaction(address,uint256,string,bytes,uint256) (contracts/timelock/Timelock.sol#191-214)
• Timelock.cancelTransaction(address,uint256,string,bytes,uint256) (contracts/timelock/Timelock.sol#222-240)
• Timelock.executeTransaction(address,uint256,string,bytes,uint256) (contracts/timelock/Timelock.sol#253-306)
• FSDVesting.propose(address[],uint256[],string[],bytes[],string,bool) (contracts/token/FSDVesting.sol#173-190)

Tools Used

Slither

Recommended Mitigation Steps

Declare those functions as external to save some gas.

[YunChe404]

8

[pauliax]

Valid suggestion, it is also a good practice to make your functions external if they are not intended to be called internally. But please note that 'external' is not always cheaper than 'public', see: https://ethereum.stackexchange.com/a/107939/17387

Making this a primary issue as it contains the most examples where this suggestion can be applied.