code-423n4 / 2021-11-fei-findings

0 stars 0 forks source link

preMergeCirculatingTribe can be constant (TRIBERagequit.sol) #158

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

ye0lde

Vulnerability details

Impact

"preMergeCirculatingTribe" can be made a constant to save gas.

Proof of Concept

preMergeCirculatingTribe is defined here: https://github.com/code-423n4/2021-11-fei/blob/add34324513b863f58e4ef7b3cd0c12d776dbb7f/contracts/TRIBERagequit.sol#L28

And used here: https://github.com/code-423n4/2021-11-fei/blob/add34324513b863f58e4ef7b3cd0c12d776dbb7f/contracts/TRIBERagequit.sol#L101

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Change "preMergeCirculatingTribe" to a constant.

elee1766 commented 2 years ago

147

pauliax commented 2 years ago

A duplicate of #147