Closed code423n4 closed 2 years ago
gzeon
It is better to have governance changeable fee (capped by certain value) instead of a static fee. Imo 1% tax for all action is too high especially if people want to actively rebalance their portfolio.
https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L558
Duplicated : #36
maximebrugel
commented
2 years ago
Handle
gzeon
Vulnerability details
Impact
It is better to have governance changeable fee (capped by certain value) instead of a static fee. Imo 1% tax for all action is too high especially if people want to actively rebalance their portfolio.
Proof of Concept
https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L558