search

code-423n4 / 2021-11-nested-findings

1 stars 1 forks source link

Unused local variables #153

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

Unused local variables in contracts increase contract size and gas usage at deployment.

Instances include:

https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L379-L383

(uint256[] memory amounts, address[] memory tokens) = OperatorHelpers.decodeDataAndRequire(
    data,
    _inputToken,
    _outputToken
);

tokens is unused.

https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L410-L414

(uint256[] memory amounts, address[] memory tokens) = OperatorHelpers.decodeDataAndRequire(
    data,
    _inputToken,
    _outputToken
);

tokens is unused.

adrien-supizet commented 2 years ago

duplicate #195

maximebrugel commented 2 years ago

also duplicate #67 & #66

alcueca commented 2 years ago

195 as the main