code-423n4 / 2021-11-nested-findings

1 stars 1 forks source link

Gas: Unnecessary `balanceOf` call #184

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

cmichel

Vulnerability details

The NestedBuybacker.triggerForToken gets the _sellToken balance but does never use this result.

// this balance is never used
uint256 balance = _sellToken.balanceOf(address(this));

A good compiler should eliminate dead code but it's better to remove unused code in the first place.

maximebrugel commented 2 years ago

Duplicated : #65