search

code-423n4 / 2021-11-nested-findings

1 stars 1 forks source link

NestedFactory._calculateFees should be pure to save on call costs #201

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

hyh

Vulnerability details

As the _calculateFees function operates only its agruments it can be pure.

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedFactory.sol#L557

maximebrugel commented 2 years ago

Duplicated : #167

alcueca commented 2 years ago

Also comments are wrong (#194)