Shortening revert strings to fit in 32 bytes will decrease deployment time gas and will decrease runtime gas when the revert condition has been met.
Revert strings that are longer than 32 bytes require at least one additional mstore, along with additional overhead for computing memory offset, etc.
I can see that the sponsor is committed to verbose revert strings as almost every revert string is > 32 bytes but I wanted to at least mention this issue.
Proof of Concept
Almost every revert string in the project is > 32 bytes.
Tools Used
Visual Studio Code
Recommended Mitigation Steps
Consider shortening the revert strings to fit in 32 bytes or using custom errors (v0.8.4 or greater) in the future.
adrien-supizet
commented
2 years ago
Handle
ye0lde
Vulnerability details
Impact
Shortening revert strings to fit in 32 bytes will decrease deployment time gas and will decrease runtime gas when the revert condition has been met. Revert strings that are longer than 32 bytes require at least one additional mstore, along with additional overhead for computing memory offset, etc.
I can see that the sponsor is committed to verbose revert strings as almost every revert string is > 32 bytes but I wanted to at least mention this issue.
Proof of Concept
Almost every revert string in the project is > 32 bytes.
Tools Used
Visual Studio Code
Recommended Mitigation Steps
Consider shortening the revert strings to fit in 32 bytes or using custom errors (v0.8.4 or greater) in the future.