code-423n4 / 2021-11-nested-findings

1 stars 1 forks source link

fillQuote returned value #222

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

function triggerForToken calls ExchangeHelpers.fillQuote and continues the execution without checking the returned value. fillQuote returns a boolean flag indicating if the low-level call succeeded or failed.

Recommended Mitigation Steps

Consider adding a require statement that this fillQuote call succeeded.

adrien-supizet commented 2 years ago

duplicate #76