search

code-423n4 / 2021-11-nested-findings

1 stars 1 forks source link

Does not check uniqueness of ShareHolder #231

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

hack3r-0m

Vulnerability details

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/FeeSplitter.sol#L264

does not check if there is already a shareholder before creating a new shareholder.

this will cause an issue in findShareHolder since it will return the first shareholder in the array while there are more than one.

alcueca commented 2 years ago

Duplicate of #135, taken as principal.