code-423n4 / 2021-11-nested-findings

1 stars 1 forks source link

`_calculateFess` takes user argument as address but unused and can be marked pure #233

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

hack3r-0m

Vulnerability details

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedFactory.sol#L557

should remove address _user since it is unutilized and mark function pure

adrien-supizet commented 2 years ago

duplicate #167

alcueca commented 2 years ago

Also comments are wrong (#194)