search

code-423n4 / 2021-11-overlay-findings

1 stars 0 forks source link

Dead code #122

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Unused state variables or functions can be removed to save some deployment gas. Examples of such code are:

  uint16 public constant MIN_FEE = 1; // 0.01%
  uint16 public constant MAX_FEE = 100; // 1.00%
  uint16 public constant MIN_MARGIN_MAINTENANCE = 100; // 1% maintenance
  uint16 public constant MAX_MARGIN_MAINTENANCE = 6000; // 60% maintenance
  bytes32 public constant MINTER = keccak256("MINTER");
  bytes32 public constant BURNER = keccak256("BURNER");
  modifier onlyGuardian
  event log(string k, uint v);
  event log_addr(string k, address v);
  uint256 public leverageMax;
mesozoic-technology commented 2 years ago

Yeah this is just languishing there until we get to the point of finalizing the contracts. Not much of a bug in my opinion though.