code-423n4 / 2021-11-overlay-findings

1 stars 0 forks source link

UniswapV3Listener.listen has debug gas check left #140

Closed code423n4 closed 2 years ago

code423n4 commented 3 years ago

Handle

hyh

Vulnerability details

Impact

Gas is overspent on a function call with results unused in production.

Proof of Concept

gas variable is unused: https://github.com/code-423n4/2021-11-overlay/blob/main/contracts/UniswapV3Listener.sol#L39

Recommended Mitigation Steps

Remove the uint gas = gasleft() line.

mesozoic-technology commented 3 years ago

This is not a part of the audit

dmvt commented 2 years ago

Invalid - out of scope