code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

Gas Optimization: Move common logic out of if block #181

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

gzeon

Vulnerability details

Impact

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L403 can be re-written from

            rewardTokenFeeAmount += feeAmt;
            rewardTokenAmount += amt;
        } else {
            amt = amount;
            rewardTokenAmount += amt;
        }

to

            rewardTokenFeeAmount += feeAmt;
        } else {
            amt = amount;
        }
        rewardTokenAmount += amt;

to reduce cdoe size