code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

No need to check fee inside factories constructor #185

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

0x0x0x

Vulnerability details

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L286

require(feePercent < 10000, "fee");

Since we already make sure that this is less than 50 bps in factory. There is no need to do this check.