code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

Incentives paid to creator instead of depositor #201

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

gzeon

Vulnerability details

Impact

The documentation is unclear, but it make little sense that incentives are only paid to the stream creator instead of depositors. This make the incentives more like donation to the creator but not actually incentivizing the stream.

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L518

brockelmore commented 2 years ago

This is intentional, will make it clear that the stream creator is the one being incentivized.

0xean commented 2 years ago

Marking as non - critical so the documentation can be updated.